aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Norris" <protoch...@gmail.com>
Subject Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
Date Wed, 09 Apr 2014 17:42:46 GMT


> On April 9, 2014, 5:35 p.m., Suman Karumuri wrote:
> > Thanks for the diff Dan. As part of the new UI roll out https://reviews.apache.org/r/19833/,
I have removed this file from the server and moved this logic into the client side. I can
add these changes as part of that diff or you can wait until that rb lands for this change.

I forgot you were working on that! If you don't mind, I'll just wait until that is committed
and use that as an opportunity to see what's new.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review39907
-----------------------------------------------------------


On April 9, 2014, 5:34 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 5:34 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
>     https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 92045c41706ee9315f3522c3b5bbff7f6e7d2c64

> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was messed up.
I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message