aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Re: Review Request 20069: Move gradlew back to project root.
Date Mon, 07 Apr 2014 15:18:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20069/#review39679
-----------------------------------------------------------

Ship it!


This was moved initially to help clean up the root of the project, intellij should be "smart"
enough to include the gradle-wrapper.jar and properties from the configured path in the wrapper
task, I would consider this a bug in intellij's gradle plugin. I'm good with moving it back
for now

- Jake Farrell


On April 6, 2014, 9:23 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20069/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 9:23 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Move gradlew back to project root.
> 
> This fixes IntelliJ integration with the gradle wrapper.
> 
> 
> Diffs
> -----
> 
>   .gitignore 7e433852ab710683f4f57912c315fce8c1e5ddea 
>   build-support/gradle/wrapper/gradle-wrapper.jar  
>   build-support/gradle/wrapper/gradle-wrapper.properties  
>   build.gradle 109c193da3324bd5534b409bfabb6aeb0adda7b1 
>   gradlew 7e2b34e7f62bbf1d6afb5df20a960742e373dc48 
> 
> Diff: https://reviews.apache.org/r/20069/diff/
> 
> 
> Testing
> -------
> 
> Opening the gradle build script in IntelliJ 13.1 Ultimate works out-of-the-box without
the need to use the idea target.
> 
> git clean -fdx
> idea build.gradle
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message