aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 20067: Add a test to validate that the tutorial instructions work.
Date Mon, 07 Apr 2014 15:17:17 GMT


> On April 7, 2014, 12:25 a.m., Maxim Khutornenko wrote:
> > examples/vagrant/test_tutorial.sh, line 6
> > <https://reviews.apache.org/r/20067/diff/1/?file=550346#file550346line6>
> >
> >     Spacing.

Never give up, never surrender!  Fixed ;-)


> On April 7, 2014, 12:25 a.m., Maxim Khutornenko wrote:
> > examples/vagrant/test_tutorial.sh, line 11
> > <https://reviews.apache.org/r/20067/diff/1/?file=550346#file550346line11>
> >
> >     "200"?

Done for consistency within the file, but this is actually unnecessary.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20067/#review39654
-----------------------------------------------------------


On April 6, 2014, 7:26 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20067/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 7:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-299
>     https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Noticed that i introduced a path name regression in aurora-thermos-observer.conf, added
test coverage for the fix.
> 
> This will be useful as we continue to change the vagrant configuration, rather than manual
verification.
> 
> 
> Diffs
> -----
> 
>   docs/tutorial.md e428f4ee1fcae89e4c865d4092738006091754ab 
>   examples/vagrant/test_tutorial.sh PRE-CREATION 
>   examples/vagrant/upstart/aurora-thermos-observer.conf 6db85aad5b0c2d484656bfb5d5bfa4ad4c9b3342

> 
> Diff: https://reviews.apache.org/r/20067/diff/
> 
> 
> Testing
> -------
> 
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message