aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 20009: Add the "open" command to clientv2, and fix an error case in v1.
Date Fri, 04 Apr 2014 18:09:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20009/#review39566
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/20009/#comment71975>

    api is not used here.



src/test/python/apache/aurora/client/cli/test_open.py
<https://reviews.apache.org/r/20009/#comment71977>

    s/2013/2014


- Maxim Khutornenko


On April 3, 2014, 4:58 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20009/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 4:58 p.m.)
> 
> 
> Review request for Aurora, David Robinson and Maxim Khutornenko.
> 
> 
> Bugs: aurora-307
>     https://issues.apache.org/jira/browse/aurora-307
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add the "open" command to clientv2, and fix an error case in v1.
> 
> Clientv2 didn't have an "open" command, which it needed. Clientv1
> had an open command, but if you used it and you forgot to specify
> the parameter, it dropped its cookies.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 83f7b6a4ae1e6896278752cb481901c6e381ba0e

>   src/main/python/apache/aurora/client/cli/jobs.py 798f54deb35afb72cd3b8d3cb972d386e48d6c2e

>   src/main/python/apache/aurora/client/commands/core.py b1abc9e7b1923d2e56f452c6891ddaa959d95b40

>   src/test/python/apache/aurora/client/cli/BUILD d93a2df0f146e2771de2ce6223438a671d0e92a2

>   src/test/python/apache/aurora/client/cli/test_open.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20009/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests, added new tests of the open command.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message