aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19900: Optional is printed in scheduler thrift response message
Date Wed, 02 Apr 2014 06:32:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19900/#review39238
-----------------------------------------------------------

Ship it!


This is now on master as 85ae33b.

- Bill Farner


On April 2, 2014, 4:03 a.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19900/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 4:03 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-249
>     https://issues.apache.org/jira/browse/AURORA-249
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Optional is printed in scheduler thrift response message
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 9ebfd943395c5a9a300a8a661357825c927893dd

> 
> Diff: https://reviews.apache.org/r/19900/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs
> 
> I wasn't sure how to get better output from the Java tests to verify this condition.
Let me know if there's something else you'd like to see done.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message