aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 19888: Prepare to store UNKNOWN state.
Date Wed, 02 Apr 2014 00:17:27 GMT


> On April 2, 2014, 12:11 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 120
> > <https://reviews.apache.org/r/19888/diff/2/?file=544897#file544897line120>
> >
> >     use List#remove(int) here, it returns the removed element.

I don't want to remove it. I am getting prev, extracting state from it and dropping last.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39220
-----------------------------------------------------------


On April 2, 2014, 12:05 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19888/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 12:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
>     https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a graceful
rollback of that change.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 6622216c285eb1c25c7648769a7d7676e8b73bcc

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/19888/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message