aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 19888: Prepare to store UNKNOWN state.
Date Tue, 01 Apr 2014 22:50:48 GMT


> On April 1, 2014, 10:43 p.m., Bill Farner wrote:
> > Isn't a StorageBackfill what you're after here?  Rewrite tasks in the UNKNOWN state
to a more appropriate state?

The StorageBackfill is a much more invasive approach, which is not really required here. Besides,
rewriting state would mess up the task events and show something like FINISHED -> UNKNOWN
-> FINISHED. Trying to minimize the impact here.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39207
-----------------------------------------------------------


On April 1, 2014, 9:52 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19888/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 9:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
>     https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a graceful
rollback of that change.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 003d475a1bd4ecc099d9a641fd239a8189f71cdb

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java d2becea60e5d7bb59a2e5adb66e10cd50f6b56f3

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java e77063a9c8e40e015ec264b151a7ed76f1c7f00f

> 
> Diff: https://reviews.apache.org/r/19888/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> gradle run
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message