Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F00610115 for ; Fri, 28 Mar 2014 00:39:47 +0000 (UTC) Received: (qmail 90724 invoked by uid 500); 28 Mar 2014 00:39:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 90130 invoked by uid 500); 28 Mar 2014 00:39:13 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 90007 invoked by uid 99); 28 Mar 2014 00:39:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2014 00:39:12 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 28 Mar 2014 00:39:10 +0000 Received: (qmail 89853 invoked by uid 99); 28 Mar 2014 00:38:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2014 00:38:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EA77E1D5BF6; Fri, 28 Mar 2014 00:38:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2291306667412594408==" MIME-Version: 1.0 Subject: Re: Review Request 19709: CrontabEntry parser From: "Bill Farner" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 28 Mar 2014 00:38:46 -0000 Message-ID: <20140328003846.4904.98558@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/19709/ X-Sender: "Bill Farner" References: <20140328001449.4904.36488@reviews.apache.org> In-Reply-To: <20140328001449.4904.36488@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2291306667412594408== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38857 ----------------------------------------------------------- Ship it! src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json As discussed offline, if you use Splitter's omitEmptyStrings() you should be able to trivially support these. - Bill Farner On March 28, 2014, 12:14 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19709/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 12:14 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-132 > https://issues.apache.org/jira/browse/AURORA-132 > > > Repository: aurora > > > Description > ------- > > Cron scheduler based on Quartz. > > Apologies for the monster diff - I will try to split it but wanted to give y'all a chance to take a look in the evening/morning. > > I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is plumbing. > > > Diffs > ----- > > build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json dced8b454c97b9c456605144161ff5c946cb384f > > Diff: https://reviews.apache.org/r/19709/diff/ > > > Testing > ------- > > ./gradlew build > > Removed a few test cases from valid-cron-schedules.json after inspection revealed they should be considered invalid. > > > Thanks, > > Kevin Sweeney > > --===============2291306667412594408==--