Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F76F10862 for ; Thu, 27 Mar 2014 21:45:03 +0000 (UTC) Received: (qmail 95489 invoked by uid 500); 27 Mar 2014 21:45:02 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 95411 invoked by uid 500); 27 Mar 2014 21:44:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 95403 invoked by uid 99); 27 Mar 2014 21:44:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2014 21:44:57 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 27 Mar 2014 21:44:54 +0000 Received: (qmail 94168 invoked by uid 99); 27 Mar 2014 21:44:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2014 21:44:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4BFC61D5BE8; Thu, 27 Mar 2014 21:44:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5084208288216988842==" MIME-Version: 1.0 Subject: Re: Review Request 19709: CrontabEntry parser From: "Bill Farner" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Kevin Sweeney" Date: Thu, 27 Mar 2014 21:44:27 -0000 Message-ID: <20140327214427.4904.99852@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/19709/ X-Sender: "Bill Farner" References: <20140327013742.29944.24716@reviews.apache.org> In-Reply-To: <20140327013742.29944.24716@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5084208288216988842== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38799 ----------------------------------------------------------- build.gradle What would it take to do that now? Is it as simple as System.setProperty? src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java doc? src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java doc? src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java Do these all need to be public? Looks like most of these accessors are only used within this class. Many others seem like they should be @VisibleTesting as well. src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java s/SINGLETON/INT/? src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java replaceNameAliases? - Bill Farner On March 27, 2014, 1:37 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19709/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 1:37 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-132 > https://issues.apache.org/jira/browse/AURORA-132 > > > Repository: aurora > > > Description > ------- > > Cron scheduler based on Quartz. > > Apologies for the monster diff - I will try to split it but wanted to give y'all a chance to take a look in the evening/morning. > > I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is plumbing. > > > Diffs > ----- > > build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f > src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java df0c37839c5da54795404c18ff9fc93084cd32e4 > src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 56e9950fd94ae1e3dbd96baec00b7e6b262fbe34 > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 7b25152c0258e10be21b801cae1444c518367fa7 > src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java a31551c77818c17ee0f9f71b5ab458a3b853dc6a > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronExpressions.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictor.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronScheduler.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 61b01d2575d6cfce069e77c39bfa8f8680cf4298 > src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 70ccf036c0676accd4a60c91bac1e6c77f365598 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12d33ffa0fc246d50ed95bb2399af9707087d068 > src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json dced8b454c97b9c456605144161ff5c946cb384f > src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java a9b85d0983dcfee89101a5e774ba86ee11708c68 > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronIT.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictorTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronSchedulerTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 033ebd29a4e95914347c1f5f8ade73115585a26f > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 380df1011cec2970dbcf37252d469dc6373b66f6 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c89965cee38a72b23fe65cb14bfa61b4cba0bfc4 > > Diff: https://reviews.apache.org/r/19709/diff/ > > > Testing > ------- > > ./gradlew build > > Removed a few test cases from valid-cron-schedules.json after inspection revealed they should be considered invalid. > > > Thanks, > > Kevin Sweeney > > --===============5084208288216988842==--