Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E69B10A15 for ; Mon, 24 Mar 2014 22:15:05 +0000 (UTC) Received: (qmail 76379 invoked by uid 500); 24 Mar 2014 22:15:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 76342 invoked by uid 500); 24 Mar 2014 22:15:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 76334 invoked by uid 99); 24 Mar 2014 22:15:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Mar 2014 22:15:04 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 24 Mar 2014 22:15:03 +0000 Received: (qmail 75461 invoked by uid 99); 24 Mar 2014 22:14:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Mar 2014 22:14:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 260951D5894; Mon, 24 Mar 2014 22:14:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6015882321629649289==" MIME-Version: 1.0 Subject: Re: Review Request 17056: fix dependencies for setup_py From: "Brian Wickman" To: "Kevin Sweeney" Cc: "Aurora" , "Brian Wickman" Date: Mon, 24 Mar 2014 22:14:34 -0000 Message-ID: <20140324221434.22042.57179@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17056/ X-Sender: "Brian Wickman" References: <20140117183754.15506.46214@reviews.apache.org> In-Reply-To: <20140117183754.15506.46214@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6015882321629649289== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38378 ----------------------------------------------------------- crap, i missed this. will merge/repost/submit. - Brian Wickman On Jan. 17, 2014, 6:37 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17056/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 6:37 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. > > > Diffs > ----- > > src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff > src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 > src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 > > Diff: https://reviews.apache.org/r/17056/diff/ > > > Testing > ------- > > > Thanks, > > Brian Wickman > > --===============6015882321629649289==--