Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2F8B10FAA for ; Fri, 14 Mar 2014 00:15:01 +0000 (UTC) Received: (qmail 74155 invoked by uid 500); 14 Mar 2014 00:14:56 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 74098 invoked by uid 500); 14 Mar 2014 00:14:54 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 73930 invoked by uid 99); 14 Mar 2014 00:14:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Mar 2014 00:14:49 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 14 Mar 2014 00:14:47 +0000 Received: (qmail 73464 invoked by uid 99); 14 Mar 2014 00:14:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Mar 2014 00:14:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4F2591D523E; Fri, 14 Mar 2014 00:14:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8096003900609502485==" MIME-Version: 1.0 Subject: Re: Review Request 19159: Add killall. From: "Mark Chu-Carroll" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" , "Mark Chu-Carroll" Date: Fri, 14 Mar 2014 00:14:21 -0000 Message-ID: <20140314001421.11093.39659@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/19159/ X-Sender: "Mark Chu-Carroll" References: <20140313235927.11093.4825@reviews.apache.org> In-Reply-To: <20140313235927.11093.4825@reviews.apache.org> Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8096003900609502485== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ ----------------------------------------------------------- (Updated March 13, 2014, 8:14 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- Get rid of the use of the disambiguator in the new killall command. Fix the end-to-end test. Bugs: aurora-260 https://issues.apache.org/jira/browse/aurora-260 Repository: aurora Description ------- Add killall. - the kill command now requires a shards parameter. - the new killall command only works when run with "--force". - killall generates a scary warning message, and pauses to give the user a chance to abort. Diffs (updated) ----- src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223 src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae Diff: https://reviews.apache.org/r/19159/diff/ Testing ------- Modified the existing kill command's test suite, adding new tests of the new functionality. All pass. [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) ============================= test session starts ============================= platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 26 items src/test/python/apache/aurora/client/commands/test_cancel_update.py .. src/test/python/apache/aurora/client/commands/test_create.py ...... src/test/python/apache/aurora/client/commands/test_diff.py ... src/test/python/apache/aurora/client/commands/test_kill.py ..... src/test/python/apache/aurora/client/commands/test_listjobs.py .. src/test/python/apache/aurora/client/commands/test_restart.py ... src/test/python/apache/aurora/client/commands/test_status.py .. src/test/python/apache/aurora/client/commands/test_update.py ... ========================= 26 passed in 11.34 seconds ========================== src.test.python.apache.aurora.client.commands.core ..... SUCCESS Thanks, Mark Chu-Carroll --===============8096003900609502485==--