Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E485100DD for ; Fri, 7 Mar 2014 00:22:56 +0000 (UTC) Received: (qmail 53060 invoked by uid 500); 7 Mar 2014 00:22:55 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 53025 invoked by uid 500); 7 Mar 2014 00:22:55 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 53016 invoked by uid 99); 7 Mar 2014 00:22:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2014 00:22:55 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 07 Mar 2014 00:22:54 +0000 Received: (qmail 51491 invoked by uid 99); 7 Mar 2014 00:22:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2014 00:22:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 96C5F1D4C46; Fri, 7 Mar 2014 00:22:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7425301352100944716==" MIME-Version: 1.0 Subject: Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code. From: "Bill Farner" To: "Suman Karumuri" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Fri, 07 Mar 2014 00:22:32 -0000 Message-ID: <20140307002232.1691.16661@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18484/ X-Sender: "Bill Farner" References: <20140225222524.30920.25020@reviews.apache.org> In-Reply-To: <20140225222524.30920.25020@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7425301352100944716== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18484/ ----------------------------------------------------------- (Updated March 7, 2014, 12:22 a.m.) Review request for Aurora, Kevin Sweeney and Suman Karumuri. Repository: aurora Description ------- These async operations already took provisions to be idempotent, but still had additional code to keep track of and clean up work made irrelevant. In this change, we explicitly lean on the fact that the operations are idempotent, and allow things like a task timeout to fire but no-op for a task that successfully made it out of a transient state. More details on specific changes: - HistoryPruner used to maintain a mapping from job key to task ID. Addressed TODO to use storage instead. - Removed collection of outstanding tasks in transient states. This was useful when vetting the feature, but is no longer used in practice. - Attempted to make HistoryPrunerTest more readable. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java c80c000ddb5627e9d753bd59e77231e3050470e5 src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 82b483b019639e6d1013f834ea047827cb171fa6 src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java 811f68c792ce8eb3f687f249307612c90091ad59 src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 71d6a9ed943306386dfe88074ee07f69f6ca15d1 Diff: https://reviews.apache.org/r/18484/diff/ Testing ------- ./gradlew build Thanks, Bill Farner --===============7425301352100944716==--