Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C906410132 for ; Thu, 6 Mar 2014 19:05:46 +0000 (UTC) Received: (qmail 1228 invoked by uid 500); 6 Mar 2014 19:05:45 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 1195 invoked by uid 500); 6 Mar 2014 19:05:44 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 1186 invoked by uid 99); 6 Mar 2014 19:05:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 19:05:43 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 06 Mar 2014 19:05:42 +0000 Received: (qmail 97898 invoked by uid 99); 6 Mar 2014 19:05:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 19:05:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 547AB1D4C04; Thu, 6 Mar 2014 19:05:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5601765282080344676==" MIME-Version: 1.0 Subject: Re: Review Request 18714: Disable log and initiate shutdown upon log storage failures. From: "Suman Karumuri" To: "Suman Karumuri" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Thu, 06 Mar 2014 19:05:20 -0000 Message-ID: <20140306190520.2625.70398@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18714/ X-Sender: "Suman Karumuri" References: <20140303233512.10089.74937@reviews.apache.org> In-Reply-To: <20140303233512.10089.74937@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5601765282080344676== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18714/#review36401 ----------------------------------------------------------- If I remember the discussion correctly, there is a race condition here, where some actions could still be performed through the memory store, between the time the storage is shutdown and the shutdown actually happens. That prompted us to do this change at the storage layer instead. Is there a reason, we are doing this change at the log layer now? - Suman Karumuri On March 3, 2014, 11:35 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18714/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:35 p.m.) > > > Review request for Aurora, Kevin Sweeney and Suman Karumuri. > > > Bugs: AURORA-221 > https://issues.apache.org/jira/browse/AURORA-221 > > > Repository: aurora > > > Description > ------- > > Disable log and initiate shutdown upon log storage failures. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 071c4fcf96099819aac6276306034434e3eec879 > src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 359f5d44e030a53cedd612a350b161b392d929c4 > > Diff: https://reviews.apache.org/r/18714/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > > --===============5601765282080344676==--