Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E1E2310AA4 for ; Mon, 3 Mar 2014 18:29:52 +0000 (UTC) Received: (qmail 14262 invoked by uid 500); 3 Mar 2014 18:29:51 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 14225 invoked by uid 500); 3 Mar 2014 18:29:51 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 14217 invoked by uid 99); 3 Mar 2014 18:29:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2014 18:29:51 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 03 Mar 2014 18:29:48 +0000 Received: (qmail 14120 invoked by uid 99); 3 Mar 2014 18:29:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2014 18:29:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EA1941D4B33; Mon, 3 Mar 2014 18:29:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1617454576874395070==" MIME-Version: 1.0 Subject: Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations. From: "Bill Farner" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Mon, 03 Mar 2014 18:29:24 -0000 Message-ID: <20140303182924.10089.69360@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18487/ X-Sender: "Bill Farner" References: <20140226001222.30920.78807@reviews.apache.org> In-Reply-To: <20140226001222.30920.78807@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1617454576874395070== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ ----------------------------------------------------------- (Updated March 3, 2014, 6:29 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description ------- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 3d0ff2dfc01404c890dc17d23c3d15732915c438 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 Diff: https://reviews.apache.org/r/18487/diff/ Testing ------- ./gradlew build Thanks, Bill Farner --===============1617454576874395070==--