Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8C3710792 for ; Sat, 1 Mar 2014 01:26:59 +0000 (UTC) Received: (qmail 14371 invoked by uid 500); 1 Mar 2014 01:26:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 14335 invoked by uid 500); 1 Mar 2014 01:26:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 14327 invoked by uid 99); 1 Mar 2014 01:26:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Mar 2014 01:26:58 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 01 Mar 2014 01:26:57 +0000 Received: (qmail 12307 invoked by uid 99); 1 Mar 2014 01:26:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Mar 2014 01:26:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 10C791D4AD2; Sat, 1 Mar 2014 01:26:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4691319715962093667==" MIME-Version: 1.0 Subject: Re: Review Request 17303: Added getJobSummary API From: "Suman Karumuri" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Suman Karumuri" Date: Sat, 01 Mar 2014 01:26:35 -0000 Message-ID: <20140301012635.8004.69688@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17303/ X-Sender: "Suman Karumuri" References: <20140226041821.31478.97810@reviews.apache.org> In-Reply-To: <20140226041821.31478.97810@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4691319715962093667== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ ----------------------------------------------------------- (Updated March 1, 2014, 1:26 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- Fixed code review nits. Bugs: AURORA-64 https://issues.apache.org/jira/browse/AURORA-64 Repository: aurora Description ------- Added getJobSummary API so it can be used by the role and role/environment page in the UI. Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant classes so it can be used by the UI and the thrift API. Added tests for new code. Moved populateJobConfig call into ReadOnlyScheduler. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/base/Tasks.java d9cb886ef333e108d5d5f86043ac80e450689894 src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7b9f185cea77825e46ecfc588c72e146cd864a32 src/main/thrift/org/apache/aurora/gen/api.thrift 3ee24c75f961af61048a78ec6c3f244361bed5bd src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TasksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 912be189583419e7201e45650d18cd24a6a5a35b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java dc557718269064a202c3e4eb1272ff2b9f209ad9 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a5fcbd465b5e07e23b24524e060cea304f102492 src/test/resources/org/apache/aurora/gen/api.thrift.md5 4e6c51d9298bf6fc1935ec9080f38726f79e7959 Diff: https://reviews.apache.org/r/17303/diff/ Testing ------- gradle clean build gradle run to test local UI. Thanks, Suman Karumuri --===============4691319715962093667==--