aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Chu-Carroll <mchucarr...@apache.org>
Subject Re: Review Request 19431: Add instance specifier syntax to clientv2
Date Thu, 27 Mar 2014 18:43:08 GMT
Bill: It's been 24 hours, and I'm still waiting on a clarification request.
Please, can you take a minute, and answer, so that I can get this review
done?

   -Mark



On Wed, Mar 26, 2014 at 3:28 PM, Mark Chu-Carroll <
mchucarroll@twopensource.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19431/
>    src/main/python/apache/aurora/client/cli/jobs.py<https://reviews.apache.org/r/19431/diff/6/?file=537713#file537713line301>
(Diff
> revision 6)
>
> 301
>
>     while len(instances_to_kill) > 0:
>
>   Sorry, I don't follow what you're suggesting here. Do you mean that you want each batch
kill to take a minimum amount of time, and so pad with sleep if the batches are fast?
>
> (In any case, that's not really part of this review; that's just change tangling that
I couldn't quickly unwind. If you want that changed, I'd like to make it a separate change.)
>
>
> - Mark Chu-Carroll
>
> On March 26th, 2014, 2:08 p.m. EDT, Mark Chu-Carroll wrote:
>   Review request for Aurora, Bill Farner and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated March 26, 2014, 2:08 p.m.*
>  *Bugs: * aurora-268 <https://issues.apache.org/jira/browse/aurora-268>
>  *Repository: * aurora
> Description
>
> Add instance specifier syntax to commands that can specify instances for clientv2.
>
> Also, while I was at it, I added the kill/killall distinction to clientv2.
>
>   Testing
>
> [sun-wukong incubator-aurora (instance-syntax)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.48 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 27 passed in 1.63 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.53 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> src.test.python.apache.aurora.client.cli.bridge                                 .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....
  SUCCESS
> [sun-wukong incubator-aurora (instance-syntax)]$
> [sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION src/main/python/apache/aurora/client/cli/*.py
> src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION = CommandOption('--instances',
type=parse_instances, dest='instances',
> src/main/python/apache/aurora/client/cli/task.py:    INSTANCES_OPTION,
> [sun-wukong incubator-aurora (instance-syntax)]$ ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 27 passed in 1.65 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.53 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.53 seconds ===========================
> src.test.python.apache.aurora.client.cli.bridge                                 .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....
  SUCCESS
>
>   Diffs
>
>    - src/main/python/apache/aurora/client/cli/context.py
>    (83f7b6a4ae1e6896278752cb481901c6e381ba0e)
>    - src/main/python/apache/aurora/client/cli/jobs.py
>    (e354ee153da3e03ce0f134ddcef65ebd2075d8b5)
>    - src/main/python/apache/aurora/client/cli/options.py
>    (040c5c213798e644ba59c4ce3f9c4fe8868af2d5)
>    - src/main/python/apache/aurora/client/cli/task.py
>    (e4ee77ede119fc1e3bd196293965073405bb48b3)
>    - src/test/python/apache/aurora/client/cli/test_kill.py
>    (208816060789a49f6c6dc5d2081bab784a8c811d)
>    - src/test/python/apache/aurora/client/cli/test_restart.py
>    (6bcdd6aab7fda259b135793378b6db731fe02601)
>    - src/test/python/apache/aurora/client/cli/util.py
>    (bc2a3e9b88947bb9ab06d945c0f154f3b19a9ff9)
>
> View Diff <https://reviews.apache.org/r/19431/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message