aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19767: CronScheduler based on Quartz
Date Fri, 28 Mar 2014 17:06:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/#review38909
-----------------------------------------------------------


I'll stand down here on the assumption that an updated diff is incoming per discussion related
to the other cron review.

- Bill Farner


On March 28, 2014, 1:02 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19767/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 1:02 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-132
>     https://issues.apache.org/jira/browse/AURORA-132
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This introduces a new CronScheduler based on Quartz and removes the NoopCronScheduler.
> 
> 
> Diffs
> -----
> 
>   build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java ec56c649116c03ef148bac916bd6691a94685bc3

>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java df0c37839c5da54795404c18ff9fc93084cd32e4

>   src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 56e9950fd94ae1e3dbd96baec00b7e6b262fbe34

>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronModule.java e0935f5eab8a101f4ce1831f260f9a23137124ce

>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 7b25152c0258e10be21b801cae1444c518367fa7

>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java a31551c77818c17ee0f9f71b5ab458a3b853dc6a

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronExpressions.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronModule.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictor.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronScheduler.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 61b01d2575d6cfce069e77c39bfa8f8680cf4298

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342

>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 70ccf036c0676accd4a60c91bac1e6c77f365598

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12d33ffa0fc246d50ed95bb2399af9707087d068

>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java a9b85d0983dcfee89101a5e774ba86ee11708c68

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronIT.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronPredictorTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzCronSchedulerTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 033ebd29a4e95914347c1f5f8ade73115585a26f

>   src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 380df1011cec2970dbcf37252d469dc6373b66f6

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
c89965cee38a72b23fe65cb14bfa61b4cba0bfc4 
> 
> Diff: https://reviews.apache.org/r/19767/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message