aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 19709: CrontabEntry parser
Date Fri, 28 Mar 2014 00:48:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19709/
-----------------------------------------------------------

(Updated March 27, 2014, 5:48 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Also fix build.gradle.


Bugs: AURORA-132
    https://issues.apache.org/jira/browse/AURORA-132


Repository: aurora


Description
-------

Cron scheduler based on Quartz.

Apologies for the monster diff - I will try to split it but wanted to give y'all a chance
to take a look in the evening/morning.

I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is plumbing.


Diffs (updated)
-----

  build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/19709/diff/


Testing
-------

./gradlew build

Removed a few test cases from valid-cron-schedules.json after inspection revealed they should
be considered invalid.


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message