aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19709: CrontabEntry parser
Date Fri, 28 Mar 2014 00:21:50 GMT


> On March 27, 2014, 9:44 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java, line 148
> > <https://reviews.apache.org/r/19709/diff/1/?file=538165#file538165line148>
> >
> >     Do these all need to be public?  Looks like most of these accessors are only
used within this class.
> >     
> >     Many others seem like they should be @VisibleTesting as well.
> 
> Kevin Sweeney wrote:
>     Feels weird to limit visibility for some fields just because of quartz's implementation
quirks here.

Less code = better?  If this were a public library i'd feel differently, but i don't see what
we stand to gain here.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19709/#review38799
-----------------------------------------------------------


On March 28, 2014, 12:14 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19709/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 12:14 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-132
>     https://issues.apache.org/jira/browse/AURORA-132
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cron scheduler based on Quartz.
> 
> Apologies for the monster diff - I will try to split it but wanted to give y'all a chance
to take a look in the evening/morning.
> 
> I'd suggest reviewing CrontabEntry and CrontabEntryTest for now - the rest is plumbing.
> 
> 
> Diffs
> -----
> 
>   build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
dced8b454c97b9c456605144161ff5c946cb384f 
> 
> Diff: https://reviews.apache.org/r/19709/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> Removed a few test cases from valid-cron-schedules.json after inspection revealed they
should be considered invalid.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message