aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19565: Role and Role/env pages for Scheduler
Date Wed, 26 Mar 2014 23:43:46 GMT


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > I tried this out locally, and the browser back button appears to be broken when
i click on a role, then a job.  Does this repro for you?
> > 
> > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption]
was changed (the button is directly to the right of the title, which i find odd.
> 
> Suman Karumuri wrote:
>     The breadcrumb bar should always come before the content. Hence, I moved it above
the title.
>     
>     I have moved the [Show/Hide Resource Consumption] beside the title to save space
and make the page more compact. Once we design the title and the button a bit (move title
to the left, button to the right, turn the button into an icon) we can make it look better.
I was planning to do this in Q2.
>     
>     I have noticed the back button issue also. But that seems to be an issue with how
ngRoute manipulates browser history. I have investigated it but didn't find a solution. So,
moved it to the back burner for now since this will be replaced with the new jobs page soon.
Let me know if you want me to investigate this further now.

We either need to fix this now or introduce them both at the same time.  I would find this
extremely frustrating behavior as a user.  If you can confirm that introducing the job page
(even with a dummy) fixes this, i'm fine to keep both reviews in flight and commit ~simultaneously.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 137
> > <https://reviews.apache.org/r/19565/diff/2/?file=535006#file535006line137>
> >
> >     Can you elaborate?  I'm not sure the TODO has enough context for me to complete
it if i wanted to.
> 
> Suman Karumuri wrote:
>     Currently, the schedule is shown as "1 * * * *". Most people don't understand what
it means. It would nice if we can show some explanation like "Run this cron job on the first
minute of every hour of every day" in a tooltip.

In that case, i vote for removal of the TODO, and possibly opening the discussion in a ticket
or IRC.  I think Kevin's data mining of in-use cron schedules may make you reconsider this
desire.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


On March 26, 2014, 11:01 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION

>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION

>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c

>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8

>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2

>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce

>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d

>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383

> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message