aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18658: GZIP HTTP thrift API responses
Date Tue, 25 Mar 2014 17:44:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18658/#review38476
-----------------------------------------------------------

Ship it!


Can you drop a comment in the code about why we don't apply the filter globally?  (Summary
of our offline discoveries.)

- Bill Farner


On March 25, 2014, 5:28 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18658/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 5:28 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> GZIP HTTP thrift API responses
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d

> 
> Diff: https://reviews.apache.org/r/18658/diff/
> 
> 
> Testing
> -------
> 
> Verified API responses are gzipped.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message