aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 19505: Die, underscores, die!
Date Fri, 21 Mar 2014 14:28:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19505/
-----------------------------------------------------------

(Updated March 21, 2014, 10:28 a.m.)


Review request for Aurora, David Robinson and Kevin Sweeney.


Changes
-------

Get the command-names as well as options.


Repository: aurora


Description
-------

Switch underscores to dashes in clientv2 options.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1

  src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6

  src/main/python/apache/aurora/client/cli/sla.py 62d13851787fd7a08fb1b9bb778e03b37aca3944

  src/test/python/apache/aurora/client/cli/test_cancel_update.py e5cd7e519ae256114b2a6662b5540daccb4ebae7

  src/test/python/apache/aurora/client/cli/test_create.py 4fff616bad121dfad7a3c20c7914a93a7ae5f7e2

  src/test/python/apache/aurora/client/cli/test_plugins.py b36e5f18e9129bc063b0f8157d0d51eff8c194d5

  src/test/python/apache/aurora/client/cli/test_quota.py 44afd74aa5b11296951f45fe7edca8cb58b0ec18

  src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953

  src/test/python/apache/aurora/client/cli/test_sla.py 46f3e8d0b6ede9da5a3eb1bfb2649834ef5ca04f


Diff: https://reviews.apache.org/r/19505/diff/


Testing
-------

[sun-wukong incubator-aurora (diedashesdie)]$ ./pants src/test/python/apache/aurora/client/cli:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=========================== 4 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=========================== 5 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

========================== 27 passed in 1.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_plugins.py ..

=========================== 2 passed in 0.54 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items

src/test/python/apache/aurora/client/cli/test_quota.py ...

=========================== 3 passed in 0.59 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=========================== 5 passed in 0.54 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=========================== 2 passed in 0.54 seconds ===========================
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message