aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19450: Added nextCronRunMs field to JobSummary.
Date Fri, 21 Mar 2014 05:34:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19450/#review38056
-----------------------------------------------------------

Ship it!


Please address comments in a follow-up.


src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/19450/#comment70023>

    s/smry/summary/



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment70024>

    Move this closer to where it's used.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment70026>

    can you be explicit here instead?



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/19450/#comment70025>

    remove extra newline


- Bill Farner


On March 21, 2014, 2:41 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19450/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 2:41 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-277
>     https://issues.apache.org/jira/browse/AURORA-277
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added nextCronRunMs field to JobSummary.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0d1e2147ce6a370962dab93383d52ddeba68efb5

>   src/main/thrift/org/apache/aurora/gen/api.thrift e64f844cbd58d92621c6c21b896a9baf0c5a5f07

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
60df209150f29e2658c47d81042bd36c57d5afef 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java e78ee7b8051bc080dbb3ed2daf72171bffe3915a

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 456634c76b9993119af2d841073c31a4a1c82ab7

> 
> Diff: https://reviews.apache.org/r/19450/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message