aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 19450: Added nextCronRunMs field to JobSummary.
Date Thu, 20 Mar 2014 22:22:37 GMT


> On March 20, 2014, 6:09 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 194
> > <https://reviews.apache.org/r/19450/diff/1/?file=529218#file529218line194>
> >
> >     Mock instead, please

Changed


> On March 20, 2014, 6:09 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 979
> > <https://reviews.apache.org/r/19450/diff/1/?file=529218#file529218line979>
> >
> >     In general, 0 is an undesirable number for cases like this when testing.  This
is because it's the default integer field value.

Agreed. Changed.


> On March 20, 2014, 6:09 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java, line 169
> > <https://reviews.apache.org/r/19450/diff/1/?file=529219#file529219line169>
> >
> >     Mock please

Changed.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19450/#review37925
-----------------------------------------------------------


On March 20, 2014, 10:22 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19450/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 10:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-277
>     https://issues.apache.org/jira/browse/AURORA-277
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added nextCronRunMs field to JobSummary.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0d1e2147ce6a370962dab93383d52ddeba68efb5

>   src/main/thrift/org/apache/aurora/gen/api.thrift e64f844cbd58d92621c6c21b896a9baf0c5a5f07

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
60df209150f29e2658c47d81042bd36c57d5afef 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java e78ee7b8051bc080dbb3ed2daf72171bffe3915a

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 456634c76b9993119af2d841073c31a4a1c82ab7

> 
> Diff: https://reviews.apache.org/r/19450/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message