aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Re: Review Request 19462: [AURORA-282] add gradle target distDeb
Date Thu, 20 Mar 2014 16:19:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19462/#review37895
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/19462/#comment69672>

    Plugins imports should be alphabetical



build.gradle
<https://reviews.apache.org/r/19462/#comment69673>

    Dependency classpath import should be alphabetical



build.gradle
<https://reviews.apache.org/r/19462/#comment69675>

    shouldnt this be in /usr/local/lib



build.gradle
<https://reviews.apache.org/r/19462/#comment69677>

    Is this needed since fileArgs default to '.'?



build.gradle
<https://reviews.apache.org/r/19462/#comment69676>

    Extra options should also include
    
    --license = "Apache 2.0 License",
    --maintainer = "Apache Aurora Developers <dev@aurora.incubator.apache.org>",
    --vendor="Apache Aurora",
    --version=$version,
    --description="Apache Aurora",



build.gradle
<https://reviews.apache.org/r/19462/#comment69674>

    Please move packaging dir to build-support/packaging


Will run through the scrips and review them when i have a change to test and run. At quick
glance looks like some spacing is off and there are some extra comments. Thanks again for
the work on this

- Jake Farrell


On March 20, 2014, 3:43 p.m., Damien Hardy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19462/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 3:43 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Bugs: AURORA-282
>     https://issues.apache.org/jira/browse/AURORA-282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a gradle target distDeb producing a deb package using fpm gradle plugin
> Should be use also to produce rpm package.
> 
> 
> Diffs
> -----
> 
>   build.gradle f38888b 
>   packaging/debian/default/aurora-scheduler PRE-CREATION 
>   packaging/debian/init.d/aurora-scheduler PRE-CREATION 
>   packaging/postinstall PRE-CREATION 
>   packaging/postuninstall PRE-CREATION 
>   packaging/preuninstall PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19462/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Damien Hardy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message