aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 19426: Don't forget to register status checker observables.
Date Wed, 19 Mar 2014 23:58:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19426/#review37827
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/executor/common/status_checker.py
<https://reviews.apache.org/r/19426/#comment69573>

    Any reason not to make this an abstractproperty? Just backwards compatibility?


- Kevin Sweeney


On March 19, 2014, 3:55 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19426/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 3:55 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Don't forget to register status checker observables.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 28e50540f4a431b78fae21200599a55e64001bc1

>   src/main/python/apache/aurora/executor/common/kill_manager.py 0d0d553932bd3504bd4ee967bb860531c03c3657

>   src/main/python/apache/aurora/executor/common/status_checker.py f94042c0e90e1b36bbb6766fcdc1c474a2e2bc05

>   src/test/python/apache/aurora/executor/test_thermos_executor.py b508eab60bc23930c9ffc3ecdd2d05b71093368e

> 
> Diff: https://reviews.apache.org/r/19426/diff/
> 
> 
> Testing
> -------
> 
> src.test.python.apache.aurora.executor.executor_builds                          .....
  SUCCESS
> src.test.python.apache.aurora.executor.gc_executor                              .....
  SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor                         .....
  SUCCESS
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message