aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.
Date Tue, 18 Mar 2014 18:38:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19323/#review37592
-----------------------------------------------------------

Ship it!



build.gradle
<https://reviews.apache.org/r/19323/#comment69191>

    +1, this was left over from debugging on my branch



src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java
<https://reviews.apache.org/r/19323/#comment69207>

    Can you convert Job to accept all fields in the constructor, and make the Job fields final?
 Lacking formal test coverage, letting the compiler catch this is the next best thing to prevent
regression.


- Bill Farner


On March 17, 2014, 11:57 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19323/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 11:57 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-271
>     https://issues.apache.org/jira/browse/AURORA-271
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added jobStats on role page. 
> 
> We have stopped counting recently failed task count which is used to display the health
badge. Since this badge is being removed from the new UI, removed it from the old UI as well.
> 
> 
> Diffs
> -----
> 
>   build.gradle f38888beb00f69f40e81c1be80f5f6ade84720ae 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 3f027032a785810bddfb3ff4dd4e472989c9493f

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ee81b494b9b4dff9839a9e32c9b81fa8ef898e1b

>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 3143c6afe8adeb18fac44e92f94b9860753c3eb0

>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7

>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 6524e2441d25de6573190866a8559be620961330

> 
> Diff: https://reviews.apache.org/r/19323/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> gradlew run
> 
> 
> File Attachments
> ----------------
> 
> job stats
>   https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message