aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19323: [BugFix] Added jobStats on old role page. Disabled job status badge.
Date Mon, 17 Mar 2014 22:26:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19323/#review37493
-----------------------------------------------------------


I started on this in parallel, and have a few additional changes i'd like you to include.
 Please have a look at the tip commit on origin/wfarner/fix_jobs_page. (Convenience link:
https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=commitdiff;h=2ce304215b099687c3d2f89701a81707a11cca7f)

Also, please remove [BugFix] from the review summary and instead link the review against the
appropriate bug.

- Bill Farner


On March 17, 2014, 10:14 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19323/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 10:14 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added jobStats on role page. 
> 
> We have stopped counting recently failed task count which is used to display the health
badge. Since this badge is being removed from the new UI, removed it from the old UI as well.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04

>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7

> 
> Diff: https://reviews.apache.org/r/19323/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> gradlew run
> 
> 
> File Attachments
> ----------------
> 
> job stats
>   https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message