aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 19159: Add killall.
Date Thu, 13 Mar 2014 23:50:54 GMT


> On March 13, 2014, 9:56 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/commands/core.py, lines 413-415
> > <https://reviews.apache.org/r/19159/diff/2/?file=518936#file518936line413>
> >
> >     I'm not a fan of embedding this sleep behavior either - this can be accomplished
with hooks. For my use case of quick iteration this adds slowness for no apparent reason.

Let's proceed without the warning and sleep for now, we can discuss the policy end of things
more offline.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37067
-----------------------------------------------------------


On March 13, 2014, 8:05 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 8:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: aurora-260
>     https://issues.apache.org/jira/browse/aurora-260
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add killall.
> 
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
>   the user a chance to abort.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223

>   src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f

> 
> Diff: https://reviews.apache.org/r/19159/diff/
> 
> 
> Testing
> -------
> 
> Modified the existing kill command's test suite, adding new tests of the new functionality.
All pass.
> 
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core                              .....
  SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message