aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 19159: Add killall.
Date Thu, 13 Mar 2014 18:56:21 GMT


> On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/core.py, line 399
> > <https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399>
> >
> >     This is deliberate: the "kill" command doesn't have a "force" option. So this
ensures that there's more than a search-and-replace killall for kill: you need to deliberately
use the killall command, and specify the force option.
> >     
> >     The require --shards is also in this change - see the change above in kill.
> 
> Maxim Khutornenko wrote:
>     Missed the --shards part, thanks. 
>
> 
> Kevin Sweeney wrote:
>     If someone is going to search-and-replace kill with killall without wanting to do
that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm
in favor of dropping this required option.
> 
> Kevin Sweeney wrote:
>     I run unqualified kill (which will now be killall) all the time when iterating on
development jobs - the only time it's extraordinary/highly unrecommended is when the target
is a production service.

Which is to say I run it when I specifically *don't* want the rolling updates behavior but
rather just want to kill and create as quickly as the scheduler can do it. Obviously this
is a very bad idea for production services but the aurora command can interact with more than
just production services. I like the killall change because it saves you from accidentally
doing it implicitly when you forgot a backslash before a newline, e.g.

aurora kill smf1/aurora/prod/some_service
  --shards=0

instead of

aurora kill smf1/aurora/prod/some_service \
  --shards=0

For the case where you're using killall you don't have the risk of this.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------


On March 12, 2014, 3:11 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 3:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: aurora-260
>     https://issues.apache.org/jira/browse/aurora-260
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add killall.
> 
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
>   the user a chance to abort.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223

>   src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f

> 
> Diff: https://reviews.apache.org/r/19159/diff/
> 
> 
> Testing
> -------
> 
> Modified the existing kill command's test suite, adding new tests of the new functionality.
All pass.
> 
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core                              .....
  SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message