aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Galloway" <tgallo...@twitter.com>
Subject Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.
Date Wed, 12 Mar 2014 22:51:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review37010
-----------------------------------------------------------


Under "Schedule Noun (Cron)" (line 218 on) you didn't add "aurora cron" before the command
examples.

line 330-1: "The context is created dynamically by the noun object owning the verb being executed."
change to "The noun object owning the executing verb dynamically creates the context."

- Tom Galloway


On March 12, 2014, 9:44 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18979/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 9:44 p.m.)
> 
> 
> Review request for Aurora, Dave Lester and Tom Galloway.
> 
> 
> Bugs: aurora-253
>     https://issues.apache.org/jira/browse/aurora-253
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an updated version of the clientv2 doc to apache.
> 
> (Also make a few changes in the interfaces to match the updated doc.)
> 
> 
> Diffs
> -----
> 
>   docs/clientv2.md PRE-CREATION 
>   src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0

>   src/main/python/apache/aurora/client/cli/jobs.py 3b327df5f9c5f1d5e7e68863191313921a8dde44

> 
> Diff: https://reviews.apache.org/r/18979/diff/
> 
> 
> Testing
> -------
> 
> n/a
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message