aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 19061: Disable kill of production jobs without force flag
Date Tue, 11 Mar 2014 19:42:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19061/
-----------------------------------------------------------

(Updated March 11, 2014, 3:42 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

fix headers.


Summary (updated)
-----------------

Disable kill of production jobs without force flag


Repository: aurora


Description (updated)
-------

Disable kill of production jobs without force flag.


Diffs
-----

  src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223

  src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f


Diff: https://reviews.apache.org/r/19061/diff/


Testing
-------

Added new test cases to the unit test for the kill command to cover the new cases. All tests,
new and old, pass.
[sun-wukong incubator-aurora (kill-force)]$ ./pants src/test/python/apache/aurora/client/commands:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .............

========================== 13 passed in 0.47 seconds ==========================
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...

========================== 26 passed in 1.35 seconds ==========================
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py ....

========================== 4 passed in 0.43 seconds ===========================
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

========================== 1 passed in 0.49 seconds ===========================
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

========================== 1 passed in 0.54 seconds ===========================
src.test.python.apache.aurora.client.commands.admin                             .....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       .....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message