aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18484: Count on task timeouts and task pruning to be idempotent, simplifying handling code.
Date Fri, 07 Mar 2014 00:22:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18484/
-----------------------------------------------------------

(Updated March 7, 2014, 12:22 a.m.)


Review request for Aurora, Kevin Sweeney and Suman Karumuri.


Repository: aurora


Description
-------

These async operations already took provisions to be idempotent, but still had additional
code to keep track of and clean up work made irrelevant.

In this change, we explicitly lean on the fact that the operations are idempotent, and allow
things like a task timeout to fire but no-op for a task that successfully made it out of a
transient state.

More details on specific changes:
- HistoryPruner used to maintain a mapping from job key to task ID.  Addressed TODO to use
storage instead.
- Removed collection of outstanding tasks in transient states.  This was useful when vetting
the feature, but is no longer used in practice.
- Attempted to make HistoryPrunerTest more readable.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java c80c000ddb5627e9d753bd59e77231e3050470e5

  src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 82b483b019639e6d1013f834ea047827cb171fa6

  src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java 811f68c792ce8eb3f687f249307612c90091ad59

  src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 71d6a9ed943306386dfe88074ee07f69f6ca15d1


Diff: https://reviews.apache.org/r/18484/diff/


Testing
-------

./gradlew build


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message