aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 17562: Added cluster name to page title.
Date Thu, 06 Mar 2014 23:43:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/
-----------------------------------------------------------

(Updated March 6, 2014, 11:43 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Fixed code review feedback.


Bugs: AURORA-120
    https://issues.apache.org/jira/browse/AURORA-120


Repository: aurora


Description
-------

Added getInfo API that returns page title and thrift API version.

Added a TitleController to UI to set the page title. The controller queries the getInfo API
to get the clusterName which is now included in the page title.

Deprecated getVersion API in favor of getInfo to obtain the thrift API version. 


Diffs (updated)
-----

  build.gradle ba83b913808ed41663e72de25f5751290057535d 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 296bc1f7f20c4d8bb0ce14dfd4f9c003473ceec7

  src/main/java/org/apache/aurora/scheduler/http/ClusterName.java ac77f6ac0b71d5b3735cb269c9bfff3e2c6fda20

  src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 3686a6682d39fa75baddfb4a1b739e14e2caf508

  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7

  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 36aa425e78c519188827c3455a0aef53b060d8eb

  src/main/java/org/apache/aurora/scheduler/http/Slaves.java cc8971ca6f4a402064a843eef5a23a47d2df06c1

  src/main/java/org/apache/aurora/scheduler/http/Utilization.java 0cbdeeafde9db05e71fdb7e71b6d4529dee9cbdd

  src/main/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptor.java e3e050e493e4a69e1d424d3382cb37f7ce6b7a4c

  src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java c68977a7cef99a31baca2043618df304298b407e

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1916ff9c02216da906af4e6164212faeff37995e

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 94189642a4f35aa0cad8176589cfbd84964c2e14

  src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cd532bdd2d34b4636d0c22494512d53a2f089463

  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java f5effe741fc37155803258fb0a3a6c7f33c2a65e

  src/test/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptorTest.java 2f0b6716fe2999c34c0351f03b6b4c1532eafee0

  src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d93ac53ec15863f2ee0e0ebc4737d8f4f8e4be9d

  src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010


Diff: https://reviews.apache.org/r/17562/diff/


Testing
-------

gradle clean build.
gradle run.


Thanks,

Suman Karumuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message