aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.
Date Thu, 06 Mar 2014 22:24:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18720/#review36441
-----------------------------------------------------------

Ship it!


only style nits


src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18720/#comment67383>

    kill []s



src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/18720/#comment67385>

    equivalent oneliner:
    
        job_keys = set(job_key_from_scheduled(t, cluster) for t in tasks) if tasks else None
 
    
    len(tasks) will always be true if tasks


- Brian Wickman


On March 4, 2014, 1:20 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18720/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 1:20 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-239
>     https://issues.apache.org/jira/browse/AURORA-239
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refactored admin client commands to take advantage of new TaskQuery fields.
> 
> The jobKeys thrift field is tracked by https://reviews.apache.org/r/18655/
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 9d9ff668496c7369c3abcf3ab3feb9d4090de6a8

>   src/main/python/apache/aurora/client/api/sla.py 71013cdab23f1d0990169555a60fcc370cc0b85c

>   src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67

>   src/test/python/apache/aurora/client/api/test_sla.py c5ef100d42cde586e8d183d0f338d6b72b8b5dbd

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 6e56bc48157efb6839e79d15cb1ba8de53ae1b7b

> 
> Diff: https://reviews.apache.org/r/18720/diff/
> 
> 
> Testing
> -------
> 
> /build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message