aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 18334: Move and unit test Maintenance module and commands
Date Wed, 05 Mar 2014 21:48:55 GMT


> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 136
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line136>
> >
> >     Not sure how I feel about this style of mock - I'd prefer the class under test
to explicitly call out "I'm using system time" to avoid missed mock coverage causing the test
suite to slow down.
> 
> Joe Smith wrote:
>     hm.. any chance you have suggestions on how to pass this through? I'd prefer not
to add it to the command line itself, I think
> 
> Kevin Sweeney wrote:
>     The clock=time pattern is more explicit to me since it's called out in production
code. In the test you can pass clock=mock_time.

ah, perhaps this is an interesting code smell then, as this is actually testing the command-line
itself, which calls the library method (that has the clock=time parameter). I'm not sure how
to go from this test (which is passing in app options) to the mock clock (maybe adding in
a mock_clock=True option..?)


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35362
-----------------------------------------------------------


On March 3, 2014, 6:50 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 6:50 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian
Wickman.
> 
> 
> Bugs: AURORA-223
>     https://issues.apache.org/jira/browse/AURORA-223
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> As always, feel free to tear it apart.
> 
> I plan to add tests for the other commands as well, but wanted to get this out sooner
than later to ensure others agreed with my approach.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386

>   src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953

>   src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0

>   src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91

>   src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0

>   src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67

>   src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION 
>   src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912

>   src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8

>   src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7

>   src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18334/diff/
> 
> 
> Testing
> -------
> 
> ./pants ./src/test/python/apache/aurora:all
> 
> particularly:
> 
> src.test.python.apache.aurora.client.commands.maintenance                       .....
  SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message