aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 18655: Added JobKey set into TaskQuery.
Date Tue, 04 Mar 2014 00:02:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review36054
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
<https://reviews.apache.org/r/18655/#comment66884>

    s/public/private/ (only used in this class), kill doc, and move closer to call site



src/main/java/org/apache/aurora/scheduler/base/Query.java
<https://reviews.apache.org/r/18655/#comment66886>

    remove extra parens around query.isSetJobKeys().  Also, if you're not scared off by the
single-letter variable name, you can reshuffle to make the precedence more clear:
    
        return (q.isSetOwner() && q.getOwner().isSetRole() && q.isSetEnvironment()
&& q.isSetJobName())
            || q.isSetJobKeys();



src/main/java/org/apache/aurora/scheduler/base/Query.java
<https://reviews.apache.org/r/18655/#comment66888>

    Iterables.getOnlyELement is a bit of a land mine.  An unsuspecting caller can hit IllegalArgumentException
or NoSuchElementException.
    
    SchedulerCoreImpl.killTasks is currently victim to this.



src/main/java/org/apache/aurora/scheduler/base/Query.java
<https://reviews.apache.org/r/18655/#comment66889>

    revert



src/main/java/org/apache/aurora/scheduler/base/Query.java
<https://reviews.apache.org/r/18655/#comment66890>

    "scoped to the jobs" rather than "scoped to the job keys"


- Bill Farner


On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18655/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 11:26 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-235
>     https://issues.apache.org/jira/browse/AURORA-235
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added an optional JobKey set filter into the TaskQuery.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95

>   src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0

>   src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00

> 
> Diff: https://reviews.apache.org/r/18655/diff/
> 
> 
> Testing
> -------
> 
> /build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message