aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 18704: Remove LogStream.close, which was a no-op everywhere.
Date Mon, 03 Mar 2014 19:15:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18704/#review36010
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On March 3, 2014, 11:05 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18704/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 11:05 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Drive-by cleanup.  Noticed only no-ops in implementations of this method, so it makes
sense to remove.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/log/Log.java 35403f33ce5583a01b8c85fd9968113cb6e153d1

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java a8e6c83e77aae894ed36e79f8cc85dcd85f75d6c

>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 5b69e4e12bb3c2ea797e9b32495699c2e243df40

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java b59b9d092b0101093621d809aea760dca2f71d42

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 040125e5f60329646b1d6356a00f5a8f1fd93b72

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94

> 
> Diff: https://reviews.apache.org/r/18704/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message