aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <>
Subject Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
Date Mon, 03 Mar 2014 18:29:24 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 3, 2014, 6:29 p.m.)

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.

Repository: aurora


There are a few nice things falling out of this refactor:
- New methods on mutable store interfaces are not implicitly forwarded
  (ForwardingStore does not implement mutable stores).
- Write ahead/behind behavior is more obvious in LogStorage
  (i found the delegation by calling super tough to catch mistakes.)
- Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of
a transaction
  (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation)

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/storage/ 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa

  src/main/java/org/apache/aurora/scheduler/storage/ 3d0ff2dfc01404c890dc17d23c3d15732915c438

  src/main/java/org/apache/aurora/scheduler/storage/log/ 1842210c91ee3e153f5d142266bc2696960535af

  src/main/java/org/apache/aurora/scheduler/storage/log/ PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/storage/log/ d6624f470eadaf0be658db1d87d5863ea6701d94



./gradlew build


Bill Farner

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message