aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 18655: Added JobKey set into TaskQuery.
Date Sat, 01 Mar 2014 01:32:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18655/#review35889
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/base/JobKeys.java
<https://reviews.apache.org/r/18655/#comment66705>

    "from" is currently intended to unambiguously give a single IJobKey instance derived from
role/env/name. I am not sure exposing a Set<IJobKey> would be a good idea. 
    


- Maxim Khutornenko


On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18655/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 12:54 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-235
>     https://issues.apache.org/jira/browse/AURORA-235
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added an optional JobKey set filter into the TaskQuery.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95

>   src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0

>   src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00

> 
> Diff: https://reviews.apache.org/r/18655/diff/
> 
> 
> Testing
> -------
> 
> /build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message