aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 17303: Added getJobSummary API
Date Sat, 01 Mar 2014 01:26:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/
-----------------------------------------------------------

(Updated March 1, 2014, 1:26 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Fixed code review nits.


Bugs: AURORA-64
    https://issues.apache.org/jira/browse/AURORA-64


Repository: aurora


Description
-------

Added getJobSummary API so it can be used by the role and role/environment page in the UI.
Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant classes so it can
be used by the UI and the thrift API.
Added tests for new code.
Moved populateJobConfig call into ReadOnlyScheduler.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/base/Tasks.java d9cb886ef333e108d5d5f86043ac80e450689894

  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7b9f185cea77825e46ecfc588c72e146cd864a32

  src/main/thrift/org/apache/aurora/gen/api.thrift 3ee24c75f961af61048a78ec6c3f244361bed5bd

  src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/base/TasksTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 912be189583419e7201e45650d18cd24a6a5a35b

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java dc557718269064a202c3e4eb1272ff2b9f209ad9

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a5fcbd465b5e07e23b24524e060cea304f102492

  src/test/resources/org/apache/aurora/gen/api.thrift.md5 4e6c51d9298bf6fc1935ec9080f38726f79e7959


Diff: https://reviews.apache.org/r/17303/diff/


Testing
-------

gradle clean build
gradle run to test local UI.


Thanks,

Suman Karumuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message