aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 18654: Adding JobKey set into TaskQuery thrift.
Date Sat, 01 Mar 2014 00:36:30 GMT


> On March 1, 2014, 12:16 a.m., Bill Farner wrote:
> > Incomplete feature?
> 
> Maxim Khutornenko wrote:
>     This is needed to unlock two additional CRs I am about to post. One that follows
up on supporting jobKeys in scheduler and the other one that uses it on the client.
> 
> Bill Farner wrote:
>     > One that follows up on supporting jobKeys in scheduler
>     
>     Why not lump that one in here?

That would serialize an otherwise ready client checking behind the scheduler one. I am ok
with that if you feel this change should not go ahead. Just wanted to optimize the flow.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18654/#review35873
-----------------------------------------------------------


On March 1, 2014, 12:14 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18654/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 12:14 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-235
>     https://issues.apache.org/jira/browse/AURORA-235
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding thrift field to unlock dependent CRs.
> 
> 
> Diffs
> -----
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00

> 
> Diff: https://reviews.apache.org/r/18654/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message