Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E78910E0E for ; Fri, 28 Feb 2014 00:19:21 +0000 (UTC) Received: (qmail 59996 invoked by uid 500); 28 Feb 2014 00:19:19 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 59959 invoked by uid 500); 28 Feb 2014 00:19:19 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 59951 invoked by uid 99); 28 Feb 2014 00:19:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2014 00:19:19 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 28 Feb 2014 00:19:17 +0000 Received: (qmail 59623 invoked by uid 99); 28 Feb 2014 00:18:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2014 00:18:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1ACDD1D4A56; Fri, 28 Feb 2014 00:18:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6543376763221691541==" MIME-Version: 1.0 Subject: Re: Review Request 18526: Add support for slaveHosts set in TaskQuery. From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 28 Feb 2014 00:18:56 -0000 Message-ID: <20140228001856.9913.62701@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18526/ X-Sender: "Maxim Khutornenko" References: <20140227164213.1890.2604@reviews.apache.org> In-Reply-To: <20140227164213.1890.2604@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6543376763221691541== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35729 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java On a second thought, it's easier to reason about all this if we treat set and non-set values the same way, namely non-null empty sets would return empty results. - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18526/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 4:42 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-232 > https://issues.apache.org/jira/browse/AURORA-232 > > > Repository: aurora > > > Description > ------- > > The slaveHosts set-based field will eventually replace a string field. > All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 > src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 > src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 > > Diff: https://reviews.apache.org/r/18526/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Maxim Khutornenko > > --===============6543376763221691541==--