Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B4050109E1 for ; Thu, 27 Feb 2014 16:42:40 +0000 (UTC) Received: (qmail 83994 invoked by uid 500); 27 Feb 2014 16:42:39 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 83957 invoked by uid 500); 27 Feb 2014 16:42:39 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 83949 invoked by uid 99); 27 Feb 2014 16:42:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 16:42:39 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 27 Feb 2014 16:42:36 +0000 Received: (qmail 81292 invoked by uid 99); 27 Feb 2014 16:42:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 16:42:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DCE031C0036; Thu, 27 Feb 2014 16:42:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1292483118929657679==" MIME-Version: 1.0 Subject: Re: Review Request 18526: Add support for slaveHosts set in TaskQuery. From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 27 Feb 2014 16:42:13 -0000 Message-ID: <20140227164213.1890.2604@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18526/ X-Sender: "Maxim Khutornenko" References: <20140226181716.7270.70204@reviews.apache.org> In-Reply-To: <20140226181716.7270.70204@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1292483118929657679== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ ----------------------------------------------------------- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- CR comments. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description ------- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing ------- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko --===============1292483118929657679==--