Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C929D10461 for ; Tue, 25 Feb 2014 02:32:36 +0000 (UTC) Received: (qmail 46275 invoked by uid 500); 25 Feb 2014 02:32:27 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 46112 invoked by uid 500); 25 Feb 2014 02:32:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 45833 invoked by uid 99); 25 Feb 2014 02:32:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 02:32:21 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 25 Feb 2014 02:32:19 +0000 Received: (qmail 45413 invoked by uid 99); 25 Feb 2014 02:31:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 02:31:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 576921D49B2; Tue, 25 Feb 2014 02:31:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8871614574782377886==" MIME-Version: 1.0 Subject: Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path From: "Kevin Sweeney" To: "Kevin Sweeney" Cc: "Dan Norris" , "Aurora" Date: Tue, 25 Feb 2014 02:31:55 -0000 Message-ID: <20140225023155.21193.89105@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18345/ X-Sender: "Kevin Sweeney" References: <20140225022138.21198.80961@reviews.apache.org> In-Reply-To: <20140225022138.21198.80961@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8871614574782377886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35366 ----------------------------------------------------------- pants Should be quoted in case $HERE is a directory containing spaces. pants Same as above - $HERE should be within double-quotes to avoid issues like ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ cmd="echo test" ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ $cmd test ksweeney@ksweeney-ThinkCentre-M93p:~/workspace/aurora$ Nit about quoting applied to each file. - Kevin Sweeney On Feb. 24, 2014, 6:21 p.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18345/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 6:21 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-225 > https://issues.apache.org/jira/browse/AURORA-225 > > > Repository: aurora > > > Description > ------- > > AURORA-225: Shell scripts in checkout should use an absolute path > > > Diffs > ----- > > build-support/pex cd083d996884681acf6f731ed24037342f2309bf > build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a > pants 4dc17fd365d8fd120c162905c41f29d92788011f > rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 > > Diff: https://reviews.apache.org/r/18345/diff/ > > > Testing > ------- > > Submitted this review with the following command: > ../rbt post -o -g (from inside of build-support directory) > > > Thanks, > > Dan Norris > > --===============8871614574782377886==--