Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89ECB10AD7 for ; Mon, 24 Feb 2014 17:36:25 +0000 (UTC) Received: (qmail 68598 invoked by uid 500); 24 Feb 2014 17:36:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 68564 invoked by uid 500); 24 Feb 2014 17:36:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 68556 invoked by uid 99); 24 Feb 2014 17:36:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Feb 2014 17:36:24 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 24 Feb 2014 17:36:21 +0000 Received: (qmail 68336 invoked by uid 99); 24 Feb 2014 17:35:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Feb 2014 17:35:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 66C4F1C764C; Mon, 24 Feb 2014 17:35:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2944299158194905322==" MIME-Version: 1.0 Subject: Re: Review Request 18334: Move and unit test Maintenance module and commands From: "Brian Wickman" To: "Brian Wickman" , "Mark Chu-Carroll" , "Kevin Sweeney" Cc: "Aurora" , "Joe Smith" Date: Mon, 24 Feb 2014 17:35:58 -0000 Message-ID: <20140224173558.21193.18682@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18334/ X-Sender: "Brian Wickman" References: <20140224071335.21193.51984@reviews.apache.org> In-Reply-To: <20140224071335.21193.51984@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2944299158194905322== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35301 ----------------------------------------------------------- src/main/python/apache/aurora/client/base.py still here? - Brian Wickman On Feb. 24, 2014, 7:13 a.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18334/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 7:13 a.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. > > > Bugs: AURORA-223 > https://issues.apache.org/jira/browse/AURORA-223 > > > Repository: aurora > > > Description > ------- > > As always, feel free to tear it apart. > > I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386 > src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953 > src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91 > src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0 > src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e > src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION > src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912 > src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8 > src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7 > src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18334/diff/ > > > Testing > ------- > > ./pants ./src/test/python/apache/aurora:all > > particularly: > > src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS > > > Thanks, > > Joe Smith > > --===============2944299158194905322==--