Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAF8D103F0 for ; Fri, 21 Feb 2014 23:00:29 +0000 (UTC) Received: (qmail 56741 invoked by uid 500); 21 Feb 2014 23:00:29 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 56704 invoked by uid 500); 21 Feb 2014 23:00:29 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 56695 invoked by uid 99); 21 Feb 2014 23:00:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 23:00:29 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 21 Feb 2014 23:00:25 +0000 Received: (qmail 56578 invoked by uid 99); 21 Feb 2014 23:00:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 23:00:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D96C41D492C; Fri, 21 Feb 2014 23:00:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3274213917728111298==" MIME-Version: 1.0 Subject: Re: Review Request 18296: Adding admin_client sla_list_safe_domain command. From: "Brian Wickman" To: "Brian Wickman" , "Mark Chu-Carroll" Cc: "Maxim Khutornenko" , "Aurora" Date: Fri, 21 Feb 2014 22:59:59 -0000 Message-ID: <20140221225959.29785.34582@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18296/ X-Sender: "Brian Wickman" References: <20140221194903.19403.54113@reviews.apache.org> In-Reply-To: <20140221194903.19403.54113@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3274213917728111298== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35203 ----------------------------------------------------------- src/main/python/apache/aurora/client/api/sla.py it looks like this was never updated. safe_hosts[host] = safe_limits != self_hosts[host].append(safe_limits) do you mean .extend()? src/main/python/apache/aurora/client/api/sla.py it looks like this was never updated. safe_hosts[host] = safe_limits != self_hosts[host].append(safe_limits) do you mean .extend()? - Brian Wickman On Feb. 21, 2014, 7:49 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18296/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 7:49 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-208 > https://issues.apache.org/jira/browse/AURORA-208 > > > Repository: aurora > > > Description > ------- > > Implemented admin_client sla_list_safe_domain command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/__init__.py 0999b6f99bd74361663258cdae9d3920b3bb636f > src/main/python/apache/aurora/client/api/sla.py b0b2b245951ea72d113ff2b3969c4d54024f73e7 > src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 > src/test/python/apache/aurora/client/api/test_sla.py 2e6c8faf668182b497df59fe41b74af240459de7 > src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30 > src/test/python/apache/aurora/client/commands/test_admin_sla.py PRE-CREATION > src/test/python/apache/aurora/client/commands/util.py 11ae990c0d8e41470c6df438d37d8a2a79907a58 > > Diff: https://reviews.apache.org/r/18296/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:all > > > Thanks, > > Maxim Khutornenko > > --===============3274213917728111298==--