Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D58E4107E7 for ; Thu, 20 Feb 2014 20:08:29 +0000 (UTC) Received: (qmail 24276 invoked by uid 500); 20 Feb 2014 20:08:29 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 24241 invoked by uid 500); 20 Feb 2014 20:08:29 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 24231 invoked by uid 99); 20 Feb 2014 20:08:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2014 20:08:28 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 20 Feb 2014 20:08:25 +0000 Received: (qmail 24094 invoked by uid 99); 20 Feb 2014 20:08:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2014 20:08:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 628181D490E; Thu, 20 Feb 2014 20:08:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4330994827194538085==" MIME-Version: 1.0 Subject: Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available. From: "Maxim Khutornenko" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Thu, 20 Feb 2014 20:08:03 -0000 Message-ID: <20140220200803.19403.41380@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18297/ X-Sender: "Maxim Khutornenko" References: <20140220184147.19403.58020@reviews.apache.org> In-Reply-To: <20140220184147.19403.58020@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4330994827194538085== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35054 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On Feb. 20, 2014, 6:41 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18297/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 6:41 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. > > I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. > > > Diffs > ----- > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > > Diff: https://reviews.apache.org/r/18297/diff/ > > > Testing > ------- > > Several orderings of invoking: > > rm aurora.iml > git clean -fdx > ./gradlew idea > > > Thanks, > > Bill Farner > > --===============4330994827194538085==--