Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E12010C5A for ; Tue, 18 Feb 2014 22:52:59 +0000 (UTC) Received: (qmail 75818 invoked by uid 500); 18 Feb 2014 22:52:58 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75784 invoked by uid 500); 18 Feb 2014 22:52:58 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 75776 invoked by uid 99); 18 Feb 2014 22:52:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 22:52:58 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 18 Feb 2014 22:52:56 +0000 Received: (qmail 75591 invoked by uid 99); 18 Feb 2014 22:52:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 22:52:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A167A1D42BE; Tue, 18 Feb 2014 22:52:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2377200103864295634==" MIME-Version: 1.0 Subject: Re: Review Request 18153: Added "sla get_job_uptime" command. From: "Maxim Khutornenko" To: "Brian Wickman" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Tue, 18 Feb 2014 22:52:33 -0000 Message-ID: <20140218225233.4362.27059@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/18153/ X-Sender: "Maxim Khutornenko" References: <20140218204602.4362.48763@reviews.apache.org> In-Reply-To: <20140218204602.4362.48763@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2377200103864295634== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ ----------------------------------------------------------- (Updated Feb. 18, 2014, 10:52 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Changes ------- CR comments. Bugs: AURORA-207 https://issues.apache.org/jira/browse/AURORA-207 Repository: aurora Description ------- Added "sla get_job_uptime" command. Also, changed from ValueError to ArgumentTypeError in options.py as the former is not handled properly by argparser and no custom messages were reported. Diffs (updated) ----- src/main/python/apache/aurora/client/api/sla.py b69d20818836fb6ae87b333e33008b27e013954f src/main/python/apache/aurora/client/cli/options.py 37f416d563b526cccf3c9cab69a5df15873db250 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/test/python/apache/aurora/client/api/test_sla.py 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 src/test/python/apache/aurora/client/cli/test_sla.py 703d39e4566a30900f1e9bcca5871c4a426cc6c3 Diff: https://reviews.apache.org/r/18153/diff/ Testing ------- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko --===============2377200103864295634==--