Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C617104E7 for ; Tue, 18 Feb 2014 15:07:22 +0000 (UTC) Received: (qmail 29432 invoked by uid 500); 18 Feb 2014 15:07:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 29404 invoked by uid 500); 18 Feb 2014 15:07:20 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 29386 invoked by uid 99); 18 Feb 2014 15:07:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 15:07:17 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 18 Feb 2014 15:07:15 +0000 Received: (qmail 29262 invoked by uid 99); 18 Feb 2014 15:06:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 15:06:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EAE601C00F6; Tue, 18 Feb 2014 15:06:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2270496262648758133==" MIME-Version: 1.0 Subject: Re: Review Request 17948: Implement help message generation for the noun/verb framework. From: "Mark Chu-Carroll" To: "David Robinson" , "Brian Wickman" Cc: "Aurora" , "Mark Chu-Carroll" Date: Tue, 18 Feb 2014 15:06:53 -0000 Message-ID: <20140218150653.4367.46256@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/17948/ X-Sender: "Mark Chu-Carroll" References: <20140211153200.9701.14717@reviews.apache.org> In-Reply-To: <20140211153200.9701.14717@reviews.apache.org> Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2270496262648758133== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ ----------------------------------------------------------- (Updated Feb. 18, 2014, 10:06 a.m.) Review request for Aurora, David Robinson and Brian Wickman. Changes ------- addressed wickman's review. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description ------- Implement help message generation for the noun/verb framework. Diffs (updated) ----- src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py 3c07c948a74bb9facb7c58e788624e1a404175d2 src/main/python/apache/aurora/client/cli/context.py 4d1de48abd571e809221fcf2487761227b212129 src/main/python/apache/aurora/client/cli/jobs.py 632c539083ba50c3115a2bddc92e4bed6bcdc782 src/main/python/apache/aurora/client/cli/options.py 017f141a605eb6b522fcd7c4fe827eefdc626fca src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/test/python/apache/aurora/client/cli/BUILD 636f407d10e85b1ffc58b72a419d81d854a40ffd src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing ------- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll --===============2270496262648758133==--